Fix RStudio installation on Debian 13 (trixie)#1397
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request updates rstudio/rstudio.sh to support Debian trixie and handles the deprecation of apt-key by falling back to gpg for key management. It also simplifies the CRAN repository configuration by writing directly to a sources list file. The review feedback suggests improving the robustness of the package installation by using the update_apt_get helper, installing dirmngr alongside gnupg, and quoting variables. Additionally, it recommends dynamically setting the CRAN repository suffix to -cran46/ for Debian bookworm and trixie to ensure compatibility with newer R versions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
DiwakarRana
force-pushed
the
main
branch
2 times, most recently
from
ae57d42 to
a518a99
Compare
|
/gcbrun |
2 participants
This PR updates the script to be compatible with Debian 13 (Trixie) and Ubuntu 24.04 (Noble) while maintaining full backward compatibility with older Dataproc versions:
-----Added a fallback to gpg if apt-key is missing (deprecated in newer OS versions).
-----Explicitly installs dirmngr alongside gnupg, which is required for GPG keyserver operations on minimal images.
-----Uses the update_apt_get helper with retries to mitigate transient network failures during key import.
-----Writes the CRAN repository definition directly to /etc/apt/sources.list.d/cran.list (faster and works out-of-the-box).
-----Dynamically selects the CRAN repository suffix: uses cran46 for Debian 12/13 (which transitioned to R 4.6+) and falls back to cran40 for Ubuntu 22/24.
-----For Debian 12 (bookworm), Debian 13 (trixie), Ubuntu 22.04 (jammy), and Ubuntu 24.04 (noble), the script now installs RStudio Server 2023.09.1-494 (which supports libssl3) instead of 1.2.5019 (which required the deprecated libssl1.1).
-----Ensures the systemd service file path is correctly mapped for these newer OS versions when running in passwordless mode.
Detailed Changes:
Modified rstudio/rstudio.sh: